Skip to content

fix: issue 1071 #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 3, 2021
Merged

fix: issue 1071 #1094

merged 3 commits into from
Mar 3, 2021

Conversation

narekcat
Copy link
Contributor

@narekcat narekcat commented Mar 1, 2021

No description provided.

Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@narekcat great finding.

It works good, just would like to improve one moment. Currenlty, when we select user the width of the field jumps, see demo video https://monosnap.com/file/BvqGuMNIyLfJG2ytnsELQaKPFnKxQM

Can we fix it so it doesn't jump when we select the user or clear it?

Another thing, could you please pull the latest changes from develop branch. Your fix is done for some outdated version, just to make sure it works good with the latest code we have in the develop branch now.

Thanks

@narekcat
Copy link
Contributor Author

narekcat commented Mar 3, 2021

Hi @maxceem . I'll fix both issues and update pull request.

@narekcat narekcat requested a review from maxceem March 3, 2021 14:34
@narekcat
Copy link
Contributor Author

narekcat commented Mar 3, 2021

@maxceem . I have updated pull request.

Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works prefectly now @narekcat.

@maxceem maxceem merged commit ccdabb4 into topcoder-platform:develop Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants